Subject Rename Dependency
Go To This Ticket's Page
Creator	Quaiche
Public or Private	Public Private tickets are only accessible to you and to DKPSystem.com staff Public Tickets are visible to everyone)
Status	Closed
Type	Bug
Section of the Site	Forum
Urgency	(1 votes)
Rating	(0 votes)
Description: Another design bug discovered while skinning our site... The forum post rename script runs on the client side. It takes a dependency on there being an element named 'pagetitle' in the DOM for it to use to pre-populate the edit box. But the <!-- System:Title --> only emits the raw text and not an enclosing <span id='pagetitle'> tag. This means that site skinners need to be aware of this dependency. Since it is undocumented as a required element in the layout.html file, I didn't catch it except by chance testing. I'm wondering how many other dependencies like this there are that I won't find until after deployment of my layout...
Official DKPSystem.com Comments No official comments yet

This is the major one. The other one, is primarily in the fact that the ability to change thread tags relies on the <!--System:PageDesc--> tag, however there is no needed id in the DOM for it to work.

This is something that needs to be fixed, I agree wholeheartedly.

--
It's all in the reflexes.

Yeah, I discovered the PageDesc issue when I took it out of our current layout and all kinds of stuff disappeared.

Might make more sense to have a family of tags...

<!-- System:PageDesc --> Textual description text ONLY
<!-- System:PageFunc --> Page functions like thread tags, etc.

Just an idea.

BTW, do you want me to find HTML bugs I file like this or as comments in forums?

--
Quaiche - Addon Author, Druid, and Guild Leader for Benevolent Thuggery on Dragonblight